Reject Empty Bundles #13798
Merged
Reject Empty Bundles #13798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
previously approved these changes
Mar 26, 2024
terencechain
requested changes
Mar 26, 2024
james-prysm
approved these changes
Mar 28, 2024
terencechain
approved these changes
Apr 1, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event the relay/builder provides us an empty bundle, we reject it and bubble up an error to the rpc call rather than allow the block to be broadcasted and processed.
Which issues(s) does this PR fix?
N.A
Other notes for review