Fix bug from PR 13827 #13871
Merged
Fix bug from PR 13827 #13871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Apr 11, 2024
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
* fix AS cache bug, tighten ro constructors * additional coverage on AS cache filter --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
PR #13827 introduced a bug where the data availability check will panic on blocks where some blobs are available locally, due to allocating a list that is too large when not all commitments need to be checked. This PR fixes that bug, adds some unit tests and tightens up some of the ROBlock/Blob constructor logic.
Thanks to @nalepae for noticing the panic in local testing and @prestonvanloon for identifying the fix.