Add electra DB #13975
Merged
Add electra DB #13975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
electra-db
branch
2 times, most recently
from
a5711b4
to
87a64f9
Compare
james-prysm
reviewed
May 9, 2024
kasey
reviewed
May 9, 2024
| @@ -51,3 +51,17 @@ func hasDenebBlindKey(enc []byte) bool { | |||
| } | |||
| return bytes.Equal(enc[:len(denebBlindKey)], denebBlindKey) | |||
| } | |||
|
|
|||
| func hasElectraKey(enc []byte) bool { | |||
| if len(electraKey) >= len(enc) { | |||
There was a problem hiding this comment.
We don't really need to do this, it would be fine to just call bytes.Equal.
There was a problem hiding this comment.
@kasey it is required or a runtime error for slice bounds out of range will happen when len(enc) is less than len(electraKey)
There was a problem hiding this comment.
You are thinking of bytes.Prefix, i think. It would be safe to call bytes.HasPrefix without this check
https://pkg.go.dev/bytes?utm_source=godoc#HasPrefix
func hasElectraKey(enc []byte) bool {
return bytes.hasPrefix(enc, electraKey)
}There was a problem hiding this comment.
You're right, this is basically replicating bytes.HasPrefix.
kasey
previously approved these changes
May 9, 2024
james-prysm
approved these changes
May 9, 2024
prestonvanloon
approved these changes
May 9, 2024
ErnestK
pushed a commit
to ErnestK/prysm
that referenced
this pull request
May 19, 2024
* Add electra DB * Fix typo * Revert deep ssz change --------- Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
* Add electra DB * Fix typo * Revert deep ssz change --------- Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds electra changes to db. Mainly two things and a note
1.) Add electra block support
2.) Add electra state support
3.) Refactor
saveStatesEfficientInternalinto multiple helpers. The functionality remains the same. It needs to be done to reduce cognitive complexity or CI will be red