Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP 7549 spectests #14027

Merged
merged 5 commits into from
Jun 10, 2024
Merged

EIP 7549 spectests #14027

merged 5 commits into from
Jun 10, 2024

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented May 21, 2024

What type of PR is this?

Tests

What does this PR do? Why is it needed?

  • Adds electra spec tests to:
    • //testing/spectest/mainnet/electra/operations
    • //testing/spectest/minimal/electra/operations
  • Changes argument of blockOperation to be consistent with other forks

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@rkapka rkapka added Ready For Review A pull request ready for code review Spec Tests Electra electra hardfork labels May 21, 2024
@rkapka rkapka requested a review from a team as a code owner May 21, 2024 03:28
@rkapka rkapka enabled auto-merge May 21, 2024 03:29
terencechain
terencechain previously approved these changes May 21, 2024
@prestonvanloon
Copy link
Member

Minimal spectests do not pass

prestonvanloon
prestonvanloon previously approved these changes May 21, 2024
# Conflicts:
#	beacon-chain/core/electra/BUILD.bazel
@rkapka rkapka dismissed stale reviews from prestonvanloon and terencechain via 5ab63c0 May 30, 2024 08:02
terencechain
terencechain previously approved these changes Jun 7, 2024
@rkapka rkapka added this pull request to the merge queue Jun 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 7, 2024
@rkapka rkapka added this pull request to the merge queue Jun 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 10, 2024
@rkapka rkapka added this pull request to the merge queue Jun 10, 2024
Merged via the queue into develop with commit b7866be Jun 10, 2024
17 checks passed
@rkapka rkapka deleted the electra-EIP7549-spectests branch June 10, 2024 16:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork Ready For Review A pull request ready for code review Spec Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants