EIP-7549: Add aggregate attestation interfaces #14029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
rkapka
force-pushed
the
eip-7549-interfaces-move
branch
from
2526056
to
ed7a52b
Compare
rkapka
force-pushed
the
eip-7549-interfaces-move
branch
from
ed7a52b
to
fb1f9c3
Compare
rkapka
commented
May 21, 2024
| @@ -1,7 +1,6 @@ | |||
| syntax = "proto3"; | |||
| package ethereum.validator.accounts.v2; | |||
|
|
|||
| import "google/protobuf/wrappers.proto"; | |||
There was a problem hiding this comment.
this is unused and the warning annoyed me
saolyn
reviewed
May 21, 2024
Comment on lines
127
to
134
| "attestationSlot1": slashing.FirstAttestation().GetData().Slot, | ||
| "beaconBlockRoot1": fmt.Sprintf("%#x", bytesutil.Trunc(slashing.FirstAttestation().GetData().BeaconBlockRoot)), | ||
| "sourceEpoch1": slashing.FirstAttestation().GetData().Source.Epoch, | ||
| "targetEpoch1": slashing.FirstAttestation().GetData().Target.Epoch, | ||
| "attestationSlot2": slashing.SecondAttestation().GetData().Slot, | ||
| "beaconBlockRoot2": fmt.Sprintf("%#x", bytesutil.Trunc(slashing.SecondAttestation().GetData().BeaconBlockRoot)), | ||
| "sourceEpoch2": slashing.SecondAttestation().GetData().Source.Epoch, | ||
| "targetEpoch2": slashing.SecondAttestation().GetData().Target.Epoch, |
There was a problem hiding this comment.
This is definitely more a nit but may improve readability here.
firstAttestation := slashing.FirstAttestation().GetData()
secondAttestation := slashing.SecondAttestation().GetData()
log.WithFields(logrus.Fields{
"attesterIndex": idx,
"blockInclusionSlot": blk.Slot(),
"attestationSlot1": firstAttestation.Slot,
"beaconBlockRoot1": fmt.Sprintf("%#x", bytesutil.Trunc(firstAttestation.BeaconBlockRoot)),
"sourceEpoch1": firstAttestation.Source.Epoch,
"targetEpoch1": firstAttestation.Target.Epoch,
"attestationSlot2": secondAttestation.Slot,
"beaconBlockRoot2": fmt.Sprintf("%#x", bytesutil.Trunc(secondAttestation.BeaconBlockRoot)),
"sourceEpoch2": secondAttestation.Source.Epoch,
"targetEpoch2": secondAttestation.Target.Epoch,
}).Info("Attester slashing was included")
There was a problem hiding this comment.
+1, except I prefer data1 and data2
saolyn
reviewed
May 21, 2024
| @@ -247,7 +248,7 @@ func (b *BeaconBlockBody) SetProposerSlashings([]*eth.ProposerSlashing) { | |||
| panic("implement me") | |||
| } | |||
|
|
|||
| func (b *BeaconBlockBody) SetAttesterSlashings([]interfaces.AttesterSlashing) { | |||
| func (b *BeaconBlockBody) SetAttesterSlashings([]ethpb.AttesterSlashing) { | |||
There was a problem hiding this comment.
Some of these receivers have pointers and others don't. If not in this PR will be worth fixing at some point
prestonvanloon
approved these changes
May 22, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Adds the following interfaces:
SignedAggregateAttAndProofAggregateAttAndProofBecause of circular dependencies, these two interfaces and the
Attestationinterface have to be defined underprotodirectory. Since it's preferable to keep all attestation-related interfaces in one place, I moved the last interface,AttesterSlashing, to theprotodirectory as well. Because of name clashes, interfaces' names useAttinstead ofAttestation.