One more validator client cleanup #14048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
more-validator-cleanup
branch
3 times, most recently
from
5d2eca5
to
cba0410
Compare
rkapka
force-pushed
the
more-validator-cleanup
branch
from
cba0410
to
1748467
Compare
saolyn
reviewed
May 29, 2024
| func (c *beaconApiValidatorClient) GetDuties(ctx context.Context, in *ethpb.DutiesRequest) (*ethpb.DutiesResponse, error) { | ||
| return wrapInMetrics[*ethpb.DutiesResponse]("GetDuties", func() (*ethpb.DutiesResponse, error) { | ||
| func (c *beaconApiValidatorClient) Duties(ctx context.Context, in *ethpb.DutiesRequest) (*ethpb.DutiesResponse, error) { | ||
| return wrapInMetrics[*ethpb.DutiesResponse]("Duties", func() (*ethpb.DutiesResponse, error) { | ||
| return c.getDuties(ctx, in) |
There was a problem hiding this comment.
Do we want to remove the get from these as well? Since the idea is the same despite not being exported
Suggested change
| return c.getDuties(ctx, in) | |
| return c.duties(ctx, in) |
rkapka
added
Ready For Review
# Conflicts: # testing/validator-mock/node_client_mock.go # validator/client/beacon-api/json_rest_handler.go # validator/client/grpc-api/grpc_validator_client.go # validator/client/iface/validator_client.go
rkapka
force-pushed
the
more-validator-cleanup
branch
from
5483aec
to
d21d203
Compare
saolyn
approved these changes
May 30, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Get/Listfrom interface method names