EIP-7549 gRPC (part 1) #14055
EIP-7549 gRPC (part 1) #14055
Conversation
rkapka
added
Ready For Review
| @@ -67,45 +69,107 @@ func (bs *Server) ListAttestations( | |||
| return nil, status.Errorf(codes.Internal, "Could not fetch attestations: %v", err) | |||
| } | |||
| case *ethpb.ListAttestationsRequest_Epoch: | |||
| if q.Epoch >= params.BeaconConfig().ElectraForkEpoch { | |||
There was a problem hiding this comment.
is this listed in the beacon api spec somewhere to have a successful response that's sort of empty?
There was a problem hiding this comment.
this is gRPC, not Beacon API
| return atts, nil | ||
| } | ||
|
|
||
| func blockIndexedAttestations[T ethpb.IndexedAtt]( |
| // The server may return an empty list when no attestations match the given | ||
| // filter criteria. This RPC should not return NOT_FOUND. Only one filter | ||
| // criteria should be used. | ||
| func (bs *Server) ListAttestationsElectra(ctx context.Context, req *ethpb.ListAttestationsRequest) (*ethpb.ListAttestationsElectraResponse, error) { |
There was a problem hiding this comment.
Most of the logic below is copied, is there a way to reduce this? or probably not
There was a problem hiding this comment.
wonder if we can use the interface here or a utility function to build the response to reduce the copy paste here
There was a problem hiding this comment.
Yes, it's a bit duplicated but the returned types are non-compatible. I would probably have to create an interface that both return types implement and given that we are getting close to deprecating gRPC, I don't think it's worth it. There's also close to 0 chance that there will be a third similar function as I don't expect attestations to change again in the F-fork.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements the following gRPC endpoints:
ListAttestationsElectraListIndexedAttestationsElectraAttestationPoolElectraSubmitAttesterSlashingElectraLogic shared by pre and post-Electra functions are extracted to generic helper functions.