Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase attestation seen cache exp time to two epochs #14156

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

terencechain
Copy link
Member

h/t to @nerolation for discovering this

We updated the expired helper to work with the Deneb boundary, which now considers the current and previous epochs. The expired helper will only return true if the attestation is older than the previous epoch. Additionally, there is a seen cache that tracks attestations the node has observed using a bitfield. This seen cache operates on a time-based expiration system, expiring entries after 32 slots. However, it has not been updated to align with Deneb behavior. As a result, the seen cache and expired helper do not align perfectly. An old attestation can remain in the pool for over 32 slots and will not be pruned until it is older than the previous epoch. This PR updates seen cache to respect expire boundary

@terencechain terencechain requested a review from a team as a code owner June 27, 2024 20:19
@terencechain terencechain added the Ready For Review A pull request ready for code review label Jun 27, 2024
@nisdas nisdas added this pull request to the merge queue Jun 28, 2024
Merged via the queue into develop with commit fa37072 Jun 28, 2024
17 checks passed
@nisdas nisdas deleted the inc-att-seen-cache-size branch June 28, 2024 00:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants