Electra: process_consolidation_requests in state transition #14219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Jul 15, 2024
| @@ -93,6 +94,8 @@ func ProcessOperations( | |||
| return nil, errors.Wrap(err, "could not process deposit receipts") | |||
| } | |||
|
|
|||
| // TODO: Process consolidations from execution header. | |||
| if err := ProcessConsolidationRequests(ctx, st, exe.ConsolidationRequests()); err != nil { | |||
| return nil, fmt.Errorf("could not process consolidation requests: %w", err) | |||
There was a problem hiding this comment.
you could also do errors.Wrap like above but either is ok
There was a problem hiding this comment.
I think we should be moving away from errors.Wrap
james-prysm
approved these changes
Jul 15, 2024
terencechain
approved these changes
Jul 15, 2024
3 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Resolves a TODO
Which issues(s) does this PR fix?
This method is primarily tested through spectests. A PR to unskip the relevant spectests is
forthcoming this week.
Other notes for review