Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electra payload fix for devnet1 #14235

Merged
merged 6 commits into from
Jul 18, 2024
Merged

electra payload fix for devnet1 #14235

merged 6 commits into from
Jul 18, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Jul 17, 2024 •
edited
Loading

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

marshalling consolidation requests was missed, adding some unit tests.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@james-prysm james-prysm added the Electra electra hardfork label Jul 17, 2024
@james-prysm james-prysm marked this pull request as ready for review July 17, 2024 22:10
@james-prysm james-prysm requested a review from a team as a code owner July 17, 2024 22:10
prestonvanloon
prestonvanloon approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. What a "fun" debugging session...

@james-prysm james-prysm added this pull request to the merge queue Jul 18, 2024
Merged via the queue into develop with commit c7e2d70 Jul 18, 2024
17 checks passed
@james-prysm james-prysm deleted the electra-payload-fixes-devnet1 branch July 18, 2024 14:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka

Assignees
No one assigned
Labels
Electra electra hardfork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-prysm @prestonvanloon