Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding corrected returns under handle error #14280

Merged
merged 2 commits into from
Jul 30, 2024
Merged

adding corrected returns under handle error #14280

merged 2 commits into from
Jul 30, 2024

Conversation

james-prysm
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

API wasn't returning on unhandled error correctly, adding in corrected returns

2024/07/30 20:42:20 http: panic serving 172.18.0.8:36946: runtime error: invalid memory address or nil pointer dereference
goroutine 219631 [running]:
net/http.(*conn).serve.func1()
	GOROOT/src/net/http/server.go:1898 +0xbe
panic({0x123fac0?, 0x43f1a60?})
	GOROOT/src/runtime/panic.go:770 +0x132
github.com/prysmaticlabs/prysm/v5/beacon-chain/rpc/eth/beacon.(*Server).getBlockV2Json(0x7efece5d2e60?, {0x1b741e0?, 0xc014be6bd0?}, {0x7efece5d2e60, 0xc012401c20}, {0x1b89908?, 0xc00da76b60?})
	beacon-chain/rpc/eth/beacon/handlers.go:153 +0x105

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@james-prysm james-prysm added Bug Something isn't working API Api related tasks labels Jul 30, 2024
@james-prysm james-prysm requested a review from a team as a code owner July 30, 2024 21:00
@james-prysm james-prysm added this pull request to the merge queue Jul 30, 2024
Merged via the queue into develop with commit 0902803 Jul 30, 2024
17 checks passed
@james-prysm james-prysm deleted the fix-beacon-handler-return branch July 30, 2024 22:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
API Api related tasks Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-prysm @rkapka