PR to fix Horusec scanner #14402
Open
PR to fix Horusec scanner #14402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Horusec doesn't seem to run with this PR? How is it broken? How can we see that it is no longer broken? |
It is running now, this is the scanner tested after the fix. And this one before the fix. I already tested it out in the former PR. The errors now are security errors due to which it is failing not due to issues in actions pipeline. |
|
@prestonvanloon review this, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Horusec scanner is not working at the moment. This PR is attempt to fix the issues its having. Currently it is complaining about docker not being found in the CI.
Added -D flag which removed requirement for running dockerised version and runs it locally using Horuser CLI