feat: add SSZ support to light client beacon api endpoints #14408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested changes
Sep 3, 2024
Comment on lines
+287
to
+299
| Pubkeys := make([][]byte, 512) | ||
| for i := range Pubkeys { | ||
| Pubkeys[i] = make([]byte, 48) | ||
| } | ||
| NextSyncCommitteeBranch := make([][]byte, 5) | ||
| for i := range NextSyncCommitteeBranch { | ||
| NextSyncCommitteeBranch[i] = make([]byte, 32) | ||
| } | ||
| update.NextSyncCommitteeBranch = NextSyncCommitteeBranch | ||
| update.NextSyncCommittee = ð.SyncCommittee{ | ||
| Pubkeys: Pubkeys, | ||
| AggregatePubkey: make([]byte, 48), | ||
| } |
There was a problem hiding this comment.
This is very wrong. You are replacing the correct data coming from NewLightClientFinalityUpdateFromBeaconState with empty values. This is what will be returned to the caller in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This pr adds SSZ support to
/eth/v1/beacon/light_client/finality_updateand/eth/v1/beacon/light_client/optimistic_updateendpoints.Which issues(s) does this PR fix?
partially addresses #12991