Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreachable code in parsing.py #3321

Closed
nnrepos opened this issue Oct 10, 2022 · 4 comments · Fixed by #3328
Closed

unreachable code in parsing.py #3321

nnrepos opened this issue Oct 10, 2022 · 4 comments · Fixed by #3328
Assignees
Labels
C: cleanup Refactoring and removing dust :) T: bug Something isn't working

Comments

@nnrepos
Copy link
Contributor

nnrepos commented Oct 10, 2022

Describe the bug

unreachable code in src\black\parsing.py:170:
raise AssertionError("INTERNAL ERROR: Tried parsing unsupported Python version!")

Expected behavior

not having unreachable code 😝

@nnrepos nnrepos added the T: bug Something isn't working label Oct 10, 2022
@calumy
Copy link

calumy commented Oct 10, 2022

@nnrepos, which versions of Python and black are you using?

@nnrepos
Copy link
Contributor Author

nnrepos commented Oct 10, 2022

@nnrepos, which versions of Python and black are you using?

this is true for any python version - i'm just doing static analysis of the main branch.

@JelleZijlstra
Copy link
Collaborator

You're right, we can remove this line.

@nnrepos
Copy link
Contributor Author

nnrepos commented Oct 10, 2022

You're right, we can remove this line.

great!
if you would like me to create a PR, please assign me to this issue 😄

@ichard26 ichard26 added the C: cleanup Refactoring and removing dust :) label Oct 10, 2022
@nnrepos nnrepos mentioned this issue Oct 11, 2022
3 tasks
JelleZijlstra pushed a commit that referenced this issue Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: cleanup Refactoring and removing dust :) T: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants