Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker builds failing on 3.12 #3919

Closed
cooperlees opened this issue Oct 3, 2023 · 0 comments · Fixed by #4055
Closed

Docker builds failing on 3.12 #3919

cooperlees opened this issue Oct 3, 2023 · 0 comments · Fixed by #4055
Assignees
@cooperlees
Labels
C: packaging Installation and packaging of Black help wanted Extra attention is needed T: bug Something isn't working

Comments

@cooperlees
Copy link
Collaborator

cooperlees commented Oct 3, 2023 •
edited
Loading

Describe the bug

Docker is failing to build aiohttp with python 3.12.

To Reproduce

Build docker with a 3.12 base image

Expected behavior

Docker to build

Environment

Black's version: [main]
OS and Python version: Debian/3.12

Additional context

This is due to aiohttp being used for blackd. THere are 3.12 wheels coming: aio-libs/aiohttp#7639
@cooperlees cooperlees added T: bug Something isn't working help wanted Extra attention is needed C: packaging Installation and packaging of Black labels Oct 3, 2023
cooperlees added a commit that referenced this issue Oct 6, 2023
@cooperlees
Set Docker to use 3.11 for now
c1ab493 
Until we get new aiohttp wheels we need to build with 3.11.
You can see an example of a fail here:

Workaround for #3919 - Will leave it open until we can move to 3.21
@cooperlees cooperlees mentioned this issue Oct 6, 2023
Merged
cooperlees added a commit that referenced this issue Oct 6, 2023
@cooperlees
Set Docker to use 3.11 for now (#3927)
738c278 
Until we get new aiohttp wheels we need to build with 3.11.
You can see an example of a fail here:

Workaround for #3919 - Will leave it open until we can move to 3.21
@cooperlees cooperlees mentioned this issue Nov 18, 2023
Merged
@cooperlees cooperlees self-assigned this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooperlees cooperlees

Labels
C: packaging Installation and packaging of Black help wanted Extra attention is needed T: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docker] Build with 3.12 image psf/black
1 participant
@cooperlees