Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that black runs with --safe by default #3378

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Conversation

mcsitter
Copy link
Contributor

@mcsitter mcsitter commented Nov 9, 2022

fixes #3375

Description

The docs had ambiguity about the --safe flag as pointed out in #3375. This PR improves the clarity of the docs.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

I don't think this needs to be noted in CHANGES.md. Of course, I can if it is desired.

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Nov 9, 2022
@JelleZijlstra
Copy link
Collaborator

Could you fix the lint issue by reformatting with prettier?

@mcsitter
Copy link
Contributor Author

Sorry, I made the changes on the GitHub page in the browser, saw the error but did not come around to fix the mishap. Should have stuck to the contributing workflow properly. My bad.

Done now!

Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants