Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional React Native example #3488

Merged
merged 11 commits into from
Nov 21, 2021
Merged

Conversation

alex-hladun
Copy link
Contributor

@alex-hladun alex-hladun commented Nov 6, 2021

This PR contains: Improved React native example implementation

Describe the problem you have without this PR

  • Outdated React-Native / Expo support. Running the tutorial did not work due to outdated Expo SDK.
  • Convert class-based component to functional and separate db initialization to separate file.
  • React native package was referenced with hard-coded SDK. Use actual version.
  • RXDB support for 4.0 added
  • Update ReadMe with new environment setup link
  • Implement native react context
  • Add 'delete hero' functionality

@@ -24,14 +24,15 @@
},
"main": "node_modules/expo/AppEntry.js",
"dependencies": {
"expo": "37.0.12",
"expo": "^43.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pin the version. We do not use package-lock for several reasons. So remove the ^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Still in draft while I sort out some jest/react-native issues

"rxdb": "file:rxdb-local.tgz",
"rxjs": "7.3.1"
"rxdb-hooks": "^4.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also pin the version here and at the line below.

@alex-hladun alex-hladun changed the title Functional react native Functional React Native example Nov 6, 2021
@alex-hladun alex-hladun marked this pull request as ready for review November 6, 2021 22:52
@alex-hladun
Copy link
Contributor Author

@pubkey Do you have any reccomendations on the failing tests?

  • react-native test fails the rxdb integrity check with a different checksum. I didn't touch the rxdb version.
  • test-browser-couch test fails due to what looks like an unrelated mocha error

Not a testing expert.

@pubkey
Copy link
Owner

pubkey commented Nov 9, 2021

Ignore test-browser-couch. It is failing at master atm, likely because github changed something in github actions which has now slower servers. I will fix this when I have time.

I am not sure about the checksum missmatch.
I would be ok with removing the yarn lock, or better completely removing yarn if we do not need it anymore.

@pubkey
Copy link
Owner

pubkey commented Nov 10, 2021

@alex-hladun do we really have to add rxdb-hooks? The problem I see is when RxDB gets breaking updates, the CI will fail until rxdb-hooks is also updated.

@alex-hladun
Copy link
Contributor Author

@alex-hladun do we really have to add rxdb-hooks? The problem I see is when RxDB gets breaking updates, the CI will fail until rxdb-hooks is also updated.

No, our team just uses it as part of our architecture. I'll take it out.

@alex-hladun
Copy link
Contributor Author

@pubkey Implemented native context and removed rxdb-hooks. Added delete hero function.

@pubkey
Copy link
Owner

pubkey commented Nov 21, 2021

Can this be merged? @alex-hladun

@alex-hladun
Copy link
Contributor Author

alex-hladun commented Nov 21, 2021 via email

@pubkey pubkey merged commit e6465c5 into pubkey:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants