Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fused_concat: Support fp8-fp32 #122

Open
wants to merge 4 commits into
base: vivianep/tcasai-benchmarking
Choose a base branch
from
Open

fused_concat: Support fp8-fp32 #122

wants to merge 4 commits into from
+42 −26

Conversation

fischeti
Copy link
Contributor

@fischeti fischeti commented Mar 20, 2024 •
edited
Loading

Almost all formats are now working:

FP64

  • NAIVE
  • OPT

FP32

  • NAIVE
  • BASELINE
  • OPT

FP16

  • BASELINE
  • OPT_EX
  • OPT

FP8

  • BASELINE: kind of works, error is not far off. Probably saturation/cancellation
  • OPT: Same

@fischeti fischeti marked this pull request as ready for review March 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colluca colluca Awaiting requested review from colluca colluca is a code owner

@viv-eth viv-eth Awaiting requested review from viv-eth viv-eth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fischeti