Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPs Proxies not working. #3036

Closed
parthaa opened this issue Aug 4, 2022 · 5 comments · Fixed by #4951
Closed

HTTPs Proxies not working. #3036

parthaa opened this issue Aug 4, 2022 · 5 comments · Fixed by #4951
Labels

Comments

@parthaa
Copy link
Contributor

parthaa commented Aug 4, 2022

Version
tfm-pulpcore-python3-pulpcore-3.17.7-1.el7.noarch
tfm-pulpcore-python3-aiohttp-3.8.1-2.el7.x86_64

Describe the bug
There was HTTPS proxy tunneling support added to the aiohttp library for 3.8.1 => aio-libs/aiohttp#5992
However pulpcore does not

  1. Have the necessary bindings to get this mode to run.
  2. Expects the CA Cert of the proxy to be concatenated to the repo's remote CA cert instead of expecting it in the default trust store (as it used to do in pulp2).

To Reproduce
Steps to reproduce the behavior:

  • Setup a https proxy or ping me about one
  • Add the proxy's cacert to the default trust store.
  • Add a repo remote with the feed and proxy urls
  • Sync

Expected behavior
Clean Sync

Actual behavior
SSL error while trying to connect to the proxy.

@parthaa
Copy link
Contributor Author

parthaa commented Aug 4, 2022

@dkliban
Copy link
Member

dkliban commented Sep 13, 2022

This works with Python 3.11. Closing the issue since Pulp is not in the position to update Python for users.

@dkliban dkliban closed this as completed Sep 13, 2022
@dralley
Copy link
Contributor

dralley commented Aug 26, 2023

@dkliban Does this work immediately with Python 3.11 or are other patches required? Because I see Partha's PR which monkeypatches the internal flag that enables this support, but that's not all it does, it does other things too.

Will we need to adopt some or all of those other changes in order for this to work? If so then this issue ought to be reopened because we won't get this resolved for free by upgrading the Python runtime.

@dkliban
Copy link
Member

dkliban commented Sep 6, 2023

This should just work with Python 3.11. There are no code changes in Pulp required.

@ggainey
Copy link
Contributor

ggainey commented Jan 22, 2024

Reopening - while python/3.11 and recent aiohttp will (finally) allow this, Pulp still needs to load the system-allowed certstore to be able to trust an HTTPS proxy's CA.

ggainey added a commit to ggainey/pulpcore that referenced this issue Jan 22, 2024
ggainey added a commit to ggainey/pulpcore that referenced this issue Jan 22, 2024
@ggainey ggainey reopened this Jan 22, 2024
ggainey added a commit to ggainey/pulpcore that referenced this issue Jan 23, 2024
dralley pushed a commit that referenced this issue Jan 24, 2024
ggainey added a commit to ggainey/pulpcore that referenced this issue Jan 24, 2024
dralley pushed a commit that referenced this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants