Skip to content

Commit

Permalink
Upgrade to grpc-js 1.10.1 & remove calls to deprecated server.start
Browse files Browse the repository at this point in the history
This matches a recent change we made to `@pulumi/pulumi`, upgrading the minimum version of `@grpc/grpc-js` to 1.10.1 and removing the deprecated `server.start()` calls that cause deprecation warnings to be printed. These calls are no longer necessary as the server is started in `server.bindAsync`.
  • Loading branch information
justinvp committed Mar 27, 2024
1 parent be4ed4e commit 47044e7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/nodejs/policy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"homepage": "https://pulumi.io",
"repository": "https://github.com/pulumi/pulumi-policy",
"dependencies": {
"@grpc/grpc-js": "^1.8.16",
"@grpc/grpc-js": "^1.10.1",
"@pulumi/pulumi": "^3.88.0",
"google-protobuf": "^3.5.0",
"protobufjs": "^7.2.4"
Expand Down
2 changes: 0 additions & 2 deletions sdk/nodejs/policy/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ export function serve(
process.exit(1);
}

server.start();

// Emit the address so the monitor can read it to connect. The gRPC server will keep the
// message loop alive.
// We explicitly convert the number to a string so that Node doesn't colorize the output.
Expand Down

0 comments on commit 47044e7

Please sign in to comment.