Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python support for policy configuration #246

Merged
merged 2 commits into from
May 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
## HEAD (unreleased)

- Increase the MaxCallRecvMsgSize for all RPC calls.
(https://github.com/pulumi/pulumi-policy/pull/239)
- Increase the MaxCallRecvMsgSize for all RPC calls
(https://github.com/pulumi/pulumi-policy/pull/239).

- Add Python support for policy configuration
(https://github.com/pulumi/pulumi-policy/pull/246).

## 1.1.0 (2020-04-17)

Expand Down
1 change: 1 addition & 0 deletions sdk/python/lib/pulumi_policy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from .policy import (
EnforcementLevel,
Policy,
PolicyConfigSchema,
PolicyCustomTimeouts,
PolicyPack,
PolicyProviderResource,
Expand Down
236 changes: 220 additions & 16 deletions sdk/python/lib/pulumi_policy/policy.py

Large diffs are not rendered by default.

44 changes: 44 additions & 0 deletions sdk/python/lib/test/test_config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Copyright 2016-2020, Pulumi Corporation.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# pylint: disable=protected-access

import unittest

from pulumi_policy.policy import EnforcementLevel, _NormalizedConfigValue, _normalize_config

class ConfigTests(unittest.TestCase):
def test_normalize_config(self):
test_cases = [
{
"config": {},
"expected": {},
},
{
"config": {"policy": EnforcementLevel.ADVISORY},
"expected": {"policy": _NormalizedConfigValue(EnforcementLevel.ADVISORY, None)},
},
{
"config": {"policy": {"foo": "bar"}},
"expected": {"policy": _NormalizedConfigValue(None, {"foo": "bar"})},
},
{
"config": {"policy": {"enforcementLevel": EnforcementLevel.ADVISORY, "foo": "bar"}},
"expected": {"policy": _NormalizedConfigValue(EnforcementLevel.ADVISORY, {"foo": "bar"})},
},
]

for test_case in test_cases:
result = _normalize_config(test_case["config"])
self.assertDictEqual(test_case["expected"], result)
39 changes: 38 additions & 1 deletion sdk/python/lib/test/test_policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

from pulumi_policy import (
EnforcementLevel,
PolicyConfigSchema,
PolicyPack,
ReportViolation,
ResourceValidationPolicy,
Expand All @@ -42,7 +43,7 @@ def report(message: str, urn: Optional[str] = None):
return violations

class PolicyPackTests(unittest.TestCase):
def test_int_raises(self):
def test_init_raises(self):
self.assertRaises(TypeError, lambda: PolicyPack(None, [NOP_POLICY]))
self.assertRaises(TypeError, lambda: PolicyPack("", [NOP_POLICY]))
self.assertRaises(TypeError, lambda: PolicyPack(1, [NOP_POLICY]))
Expand All @@ -60,6 +61,19 @@ def test_int_raises(self):
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], ""))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], 1))

el = EnforcementLevel.ADVISORY
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, ""))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, 1))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, []))

self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, {1: 1}))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, {"p": None}))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, {"p": ""}))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, {"p": 1}))
self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, {"p": []}))

self.assertRaises(TypeError, lambda: PolicyPack("policies", [NOP_POLICY], el, {"p": {1: 1}}))

class ResourceValidationPolicyTests(unittest.TestCase):
def test_init_raises(self):
self.assertRaises(TypeError, lambda: ResourceValidationPolicy(None, "desc", NOP))
Expand Down Expand Up @@ -252,3 +266,26 @@ def test_validate(self):
policy = self.Subclass()
violations = run_policy(policy)
self.assertEqual(["first", "second"], violations)


class PolicyConfigSchemaTests(unittest.TestCase):
def test_init_raises(self):
self.assertRaises(TypeError, lambda: PolicyConfigSchema(None))
self.assertRaises(TypeError, lambda: PolicyConfigSchema(""))
self.assertRaises(TypeError, lambda: PolicyConfigSchema(1))
self.assertRaises(TypeError, lambda: PolicyConfigSchema([]))
self.assertRaises(TypeError, lambda: PolicyConfigSchema({"enforcementLevel": {}}))

self.assertRaises(TypeError, lambda: PolicyConfigSchema({}, ""))
self.assertRaises(TypeError, lambda: PolicyConfigSchema({}, 1))
self.assertRaises(TypeError, lambda: PolicyConfigSchema({}, [None]))
self.assertRaises(TypeError, lambda: PolicyConfigSchema({}, [1]))
self.assertRaises(TypeError, lambda: PolicyConfigSchema({}, ["enforcementLevel"]))

def test_init(self):
PolicyConfigSchema({})
PolicyConfigSchema({"foo": {}})
PolicyConfigSchema({"foo": {"type": "string"}})

PolicyConfigSchema({}, [])
PolicyConfigSchema({}, ["foo"])
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
runtime: python
Loading