Allow management of the docker-ce-cli package #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
docker is a classBreaking changes to this file WILL impact these 14 modules (exact match):Breaking changes to this file MAY impact these 23 modules (near match):
docker::install is a classthat may have no external impact to Forge modules. docker::params is a classthat may have no external impact to Forge modules. This module is declared in 6 of 576 indexed public
|
kenyon
force-pushed
the
manage-docker-ce-cli
branch
from
099ad71
to
16c9dbc
Compare
|
Can we get a review and merge this? |
|
Hi @kenyon, thank you for your contribution. Please sign the cla in order to get this merged. kind regards, |
adrianiurca
previously approved these changes
Apr 26, 2021
|
Let's go with trivial patch exemption. |
adrianiurca
changed the title
kenyon
changed the title
Manage the docker-ce-cli package the same way as the docker-ce package. Fixes puppetlabs#597. Also remove obsolete manual setting of package provider.
kenyon
force-pushed
the
manage-docker-ce-cli
branch
from
16c9dbc
to
18efeb5
Compare
|
Just rebased. @adrianiurca can we get this merged? |
adrianiurca
approved these changes
Jun 28, 2021
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Feb 13, 2022
In puppetlabs#740 I mistakenly added code that manages the docker-ce-cli package when managing the "docker" package. The docker-ce-cli package should only be managed when also managing the docker-ce package. Fixes puppetlabs#797
vchepkov
pushed a commit
to vchepkov/puppetlabs-docker
that referenced
this pull request
May 5, 2022
In puppetlabs#740 I mistakenly added code that manages the docker-ce-cli package when managing the "docker" package. The docker-ce-cli package should only be managed when also managing the docker-ce package. Fixes puppetlabs#797
vchepkov
pushed a commit
to vchepkov/puppetlabs-docker
that referenced
this pull request
May 5, 2022
In puppetlabs#740 I mistakenly added code that manages the docker-ce-cli package when managing the "docker" package. The docker-ce-cli package should only be managed when also managing the docker-ce package. Fixes puppetlabs#797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manage the docker-ce-cli package the same way as the docker-ce package.
Fixes #597, #690.
Also remove obsolete manual setting of package provider.