Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose to handle symbols #834

Merged
merged 1 commit into from
May 30, 2022
Merged

Update Docker Compose to handle symbols #834

merged 1 commit into from
May 30, 2022

Conversation

sili72
Copy link
Contributor

@sili72 sili72 commented May 25, 2022

No description provided.

@sili72 sili72 requested a review from a team as a code owner May 25, 2022 09:31
@CLAassistant
Copy link

CLAassistant commented May 25, 2022

CLA assistant check
All committers have signed the CLA.

@smortex
Copy link
Collaborator

smortex commented May 26, 2022

@sili72 can you please elaborate on what this is intended to fix? Thanks!

@tuxmea
Copy link

tuxmea commented May 30, 2022

@bastelfreak

Can someone please retrigger the Windows 2022 tests.

Failing reason:

RuntimeError:
        {"_error"=>{"details"=>{}, "kind"=>"puppetlabs.tasks/connect-error", "msg"=>"Timeout after 10 seconds connecting to http://35.230.80.103:5985/wsman", "issue_code"=>"CONNECT_ERROR"}}

@tuxmea
Copy link

tuxmea commented May 30, 2022

@sili72 can you please elaborate on what this is intended to fix? Thanks!

@smortex When running docker compose it can happen that the output contain symbols.
As of Puppet 7 and the underlying Ruby Version have a breaking change in yaml.safe_load, we must explicitly allow symbols.

@chelnak
Copy link
Contributor

chelnak commented May 30, 2022

@tuxmea Just to clarify, by symbols do you mean extended ASCII characters?

@chelnak
Copy link
Contributor

chelnak commented May 30, 2022

@bastelfreak

Can someone please retrigger the Windows 2022 tests.

Failing reason:


RuntimeError:

        {"_error"=>{"details"=>{}, "kind"=>"puppetlabs.tasks/connect-error", "msg"=>"Timeout after 10 seconds connecting to http://35.230.80.103:5985/wsman", "issue_code"=>"CONNECT_ERROR"}}

I'll do this now.

If you ever need us, you should be able to ping out group @puppetlabs/modules 🙂

@tuxmea
Copy link

tuxmea commented May 30, 2022

@tuxmea Just to clarify, by symbols do you mean extended ASCII characters?

@chelnak No, its about ruby symbols. Maybe the following link helps: https://www.ctrl.blog/entry/ruby-psych4.html

@chelnak
Copy link
Contributor

chelnak commented May 30, 2022

@tuxmea Just to clarify, by symbols do you mean extended ASCII characters?

@chelnak No, its about ruby symbols. Maybe the following link helps: https://www.ctrl.blog/entry/ruby-psych4.html

Fantastic, thanks so much for that link. Makes sense now. I can see that there has been a similar issue with vmpooler.

I'll be working on docker today so will get this merged once CI completes 😄

@LukasAud LukasAud merged commit a2bcdd5 into puppetlabs:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants