Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-785) Fix duplicate stack matching #836

Merged
merged 3 commits into from
May 30, 2022

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented May 30, 2022

This PR is a duplicate of #785 for purpose of merging the change.

Commit has been cherry-picked from the original PR.

RXM307 and others added 2 commits May 30, 2022 09:50
Fix Duplicate Stack Matching  where part of the stack name exists in another stack
@chelnak chelnak requested a review from a team as a code owner May 30, 2022 08:56
@puppet-community-rangefinder
Copy link

docker::stack is a type

that may have no external impact to Forge modules.

This module is declared in 6 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud merged commit 9ed030c into main May 30, 2022
@LukasAud LukasAud deleted the GH-785-fix_duplicate_stack_matching branch May 30, 2022 13:43
@chelnak chelnak added the bugfix label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants