Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd service overrides: restore whitespace to pre-conversion #983

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

kenyon
Copy link
Contributor

@kenyon kenyon commented Jul 3, 2024

When these templates were converted from ERB to EPP in commit 3e101cb (#944), these lines were swapped, causing a whitespace change and unnecessary service restarts.

@kenyon kenyon requested a review from a team as a code owner July 3, 2024 22:42
@kenyon kenyon mentioned this pull request Jul 3, 2024
3 tasks
When these templates were converted from ERB to EPP in commit
3e101cb (puppetlabs#944), these lines were
swapped, causing a whitespace change and unnecessary service restarts.
@Ramesh7 Ramesh7 merged commit 707a118 into puppetlabs:main Jul 12, 2024
16 of 29 checks passed
@weastur
Copy link

weastur commented Jul 15, 2024

Well, now it causing restart while upgrading 10.0.0 -> 10.0.1.
It was major upgrade 9 -> 10, so the restart, despite its useless, was acceptable.
Now, the minor upgrade cause restart.
Please, don't do like this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants