-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minor device no and persist options #119
add minor device no and persist options #119
Conversation
newparam(:minor) do | ||
desc "Set the minor number" | ||
validate do |value| | ||
unless value =~ /^(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about if value.to_i > 255 or value.to_i < 0
instead of a regex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a fair cop, guv.
A couple notes:
|
Changes following comments on original pull request
5500ea6
to
49faba3
Compare
Updated to address @hunner's comment, and @bmjen's 2nd point. Regarding the README, I'd be happy to add the new params and some examples to the README if it were in some sort of sane format that made that relatively easy. However, it seems to me that the README needs a complete overhaul to bring it into line with the recommended standard layout. I think that is out of the scope of this PR. |
…sist_options add minor device no and persist options
Thi issue should be closed rigth https://tickets.puppetlabs.com/browse/MODULES-2261? |
I needed to create LVs with persistent block device IDs (for use a ext4 journal devices)
This change surfaces the --persistence and --minor options to the lvcreate command.