Don't execute the lvm commands when not supported. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithj4
changed the title
When lvm_support was not present, facter would still attempt to execute the vgs and pvs commands.
|
@smithj4 many thanks for your contribution. |
|
@pmcmaw Any chance of getting a puppetlabs-lvm module release with this fix included? |
|
Hey @fatmcgav, |
|
Version 1.0.1 has now been released. Thank you for your patience @fatmcgav |
|
@pmcmaw Cheers for the quick turn-around :D |
jograb
pushed a commit
to jograb/puppetlabs-lvm
that referenced
this pull request
Nov 20, 2018
Unfortunately you've deleted the changes, merged in puppetlabs#193 with the new release 1.1.0. Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/cache/lib/facter/lvm_support.rb: execution of command "vgs -o name --noheadings 2>/dev/null" failed: command not found.
This was referenced Nov 20, 2018
tphoney
added a commit
that referenced
this pull request
Dec 19, 2018
Don't execute the lvm commands when not supported. #193
|
For anyone landing here, it seems that version 1.1.0 misses this PR, while 1.2.0 brings it back. So if you need this patch, remember to use at least version 1.2.0. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Jun 4, 2020
Don't execute the lvm commands when not supported.
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Jun 4, 2020
Unfortunately you've deleted the changes, merged in puppetlabs#193 with the new release 1.1.0. Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/cache/lib/facter/lvm_support.rb: execution of command "vgs -o name --noheadings 2>/dev/null" failed: command not found.
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Jun 4, 2020
Don't execute the lvm commands when not supported. puppetlabs#193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lvm_support was not present, facter would still attempt to execute the vgs and pvs commands.