Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge removed public certificates #32

Closed
olifre opened this issue Oct 31, 2018 · 0 comments
Closed

Purge removed public certificates #32

olifre opened this issue Oct 31, 2018 · 0 comments

Comments

@olifre
Copy link
Contributor

olifre commented Oct 31, 2018

Currently, the code in certificates.pp does:

file { "${::settings::ssldir}/certs":
      ensure  => directory,
      recurse => true,
      ignore  => 'pe-internal-*',
      source  => "puppet://${::settings::ca_server}/public_certificates/", # lint:ignore:puppet_url_without_modules
}

This leaves old public certificates which may have been revoked in place on the puppet masters, and allows the corresponding machine to access secure data via node_encrypt.

I would propose to add:

purge => true,

to clean up removed cruft.

binford2k added a commit that referenced this issue Jan 15, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-node_encrypt that referenced this issue Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant