Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages.json: support (require?) SHA in addition to version #55

Open
matthewleon opened this issue Aug 9, 2017 · 4 comments
Open

packages.json: support (require?) SHA in addition to version #55

matthewleon opened this issue Aug 9, 2017 · 4 comments

Comments

@matthewleon
Copy link
Contributor

Requiring a hash in addition to the version tag would be a cheap additional layer of security. As it stands, a package author could maliciously amend a tag in their git repo, no?

@paf31
Copy link
Contributor

paf31 commented Aug 9, 2017

Sounds like a good idea.

@matthewleon
Copy link
Contributor Author

matthewleon commented Aug 10, 2017

Adding this here as a related consideration: https://theupdateframework.github.io/

Since hackage implements this, it might not be too hard to steal code from them at some future point. https://github.com/haskell/hackage-security

This might not be applicable given that psc-package works in a fundamentally different way from Hackage, but at least there might be some ideas to take inspiration from.

@Pauan
Copy link

Pauan commented Aug 10, 2017

@matthewleon
Copy link
Contributor Author

matthewleon commented Aug 10, 2017

@Pauan thanks. Good to see I'm not the only one with this concern. I will do some reading and have a think.

Rembane pushed a commit to Rembane/psc-package that referenced this issue May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants