Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow revision #45

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Commits on Jun 13, 2017

  1. First stab at allowing branch, tag or SHA

    This could be a half-measure for purescript#33. This does not prevent usage of
    master, but it arguably does behave how you'd expect: it always keeps
    whatever reference you're using as a package set up to date, and
    happens to also allow you to use a SHA in addition to a revision. I'm
    going to give this a spin, but if we later wanted to disallow
    branches, we could probably cobble together a git command that would
    tell us if a tree-ish or whatever they call it is a branch or not.
    MichaelXavier committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    e761abb View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. Quieter output

    view actually dumps the exit status, sh does not.
    MichaelXavier committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    aff276f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    159343d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2017

  1. Configuration menu
    Copy the full SHA
    1075cdb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Implement new cloning logic

    This is for purescript#45. We'll see what the tests say.
    
    Summary:
    * I use a newtype for Repo since things were starting to get
    complicated differentiating it from tags. Hope that's ok.
    * I use the ls-remote trick (you're a lifesaver, @Pauan!) to pull
      refs. If the ref is *proven* to be a branch, bail out with an
      error. If its *proven* to be a tag, we can shortcut the clone
      without running a checkout afterwards. Otherwise, assume its a SHA.
    * Restore the "exists" checks since we have decided to treat SHAs and
      tags as immutable. This should avoid unnecessary network calls on
      subsequent runs.
    MichaelXavier committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    9d5c6f7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'upstream-master' into allow-revision

    Conflicts:
    	app/Main.hs
    MichaelXavier committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    b313d07 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2017

  1. Indent wheres

    MichaelXavier committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    2da6fb4 View commit details
    Browse the repository at this point in the history
  2. Remove redundancy

    MichaelXavier committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    4c81122 View commit details
    Browse the repository at this point in the history
  3. Use --heads --tags --refs in ls-remote

    As per @Paun's suggestion as it returns less extraneous data this way.
    MichaelXavier committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    b69be29 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2017

  1. Switch to offline clone target type inference

    In response to recent comments in purescript#45. Now we don't need an expensive
    ls-remote call to determine if a clone target is a tag or sha. I'm
    still lacking a good way to test this out though.
    MichaelXavier committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    cb46cce View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. Remove // from reference parsing

    This is in accordance to the comments in purescript#45
    MichaelXavier committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    71c8a53 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2018

  1. Update clone target parser's shema parsing

    The drop call was not updated when we went from "scheme://identifier"
    to "scheme:identifier" and was eating 2 characters from the identifier
    when a scheme was specified.
    MichaelXavier committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    a5d4df3 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Configuration menu
    Copy the full SHA
    cd86c43 View commit details
    Browse the repository at this point in the history