Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon! #65

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Favicon! #65

merged 1 commit into from
Mar 7, 2016

Conversation

texastoland
Copy link

Fix #21.

32 and 256 px icons rendered from AI file using Autodesk Graphic with canvas cropped to 120 px and bundled using Icon Composer for Xcode:

  1. 32 px instead of 16 for HiDPI cf. HiDPI (32x32px) favicon.ico h5bp/html5-boilerplate#1285. Rendered at 49 px then cropped and overexposed using Acorn.
  2. 256 px for app icons; untested. Rendered at 259 px then cropped using Acorn.

Let me know if the PNGs should be uploaded to the logo repo.

Fix #21.

32 and 256 px icons rendered from AI file using Autodesk Graphic with canvas cropped to 120 px and bundled using Icon Composer for Xcode:

1. 32 px instead of 16 for HiDPI cf. h5bp/html5-boilerplate#1285. Rendered at 49 px then cropped and overexposed using Acorn.
2. 256 px for app icons; untested. Rendered at 259 px then cropped using Acorn.

Let me know if the PNGs should be uploaded to the logo repo.
paf31 added a commit that referenced this pull request Mar 7, 2016
@paf31 paf31 merged commit c5b6198 into purescript:master Mar 7, 2016
@paf31
Copy link
Contributor

paf31 commented Mar 7, 2016

Thanks! Please feel free to make a PR on the logo repo, if you like.

@paf31
Copy link
Contributor

paf31 commented Mar 7, 2016

Actually, now I see this, I wonder if it would look better inverted with the background made transparent. What do you think?

@texastoland
Copy link
Author

I wondered too. It's an easy enough fix. Your call!

@paf31
Copy link
Contributor

paf31 commented Mar 7, 2016

Yeah, let's try it then.

@garyb
Copy link
Member

garyb commented Mar 7, 2016

I had trouble getting the icon to look right at small sizes too, I got annoyed at a certain point and gave up but then forgot to come back to it... I think either this way or on a transparent background had issues, but it's worth trying again, sure.

@texastoland
Copy link
Author

Yeah I tried several different tacts (including manually drawing) but ended up exporting the vector at the right size and post processing in raster. I also made a 16 px version for the ico but the browser used it instead of 32 on my retina so I left it out. I'll try to get to it this evening and post a screenshot here.

@texastoland texastoland mentioned this pull request Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants