Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior when searching already searched string on the current page #605

Closed
jdujava opened this issue Jun 22, 2024 · 0 comments · Fixed by #606
Closed

Weird behavior when searching already searched string on the current page #605

jdujava opened this issue Jun 22, 2024 · 0 comments · Fixed by #606

Comments

@jdujava
Copy link
Contributor

jdujava commented Jun 22, 2024

Consider following scenario:

  • searching for "foo" there is only one match — zathura jumps to corresponing page
  • searching for it again with /foo leads to Pattern not found: foo error message

If the search was aborted via Esc or the document was scrolled to another page, calling /foo correctly jumps back to the only match.

Or similarly, consider following:

  • searching for "bar" with more matches on the same page
  • repeating the search /bar always jumps to the second match

This also doesn't happen when aborting or scrolling to different page before repeating the search command.

jdujava added a commit to jdujava/zathura that referenced this issue Jun 22, 2024
Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
jdujava added a commit to jdujava/zathura that referenced this issue Jun 22, 2024
Accept the first match after initiating new search.

Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
sebastinas pushed a commit that referenced this issue Jun 22, 2024
Accept the first match after initiating new search.

Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant