-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset adjust mode when hiding inputbar #588
base: develop
Are you sure you want to change the base?
Conversation
Zathura sets a special adjust mode before showing the inputbar. Remaining in that mode after it has been hidden breaks things like rotation, so reset to none.
Woudn't it be nice to restore the adjust mode to the value before entering the inputbar? |
Yeah, I've thought of this too. This technically isn't a regression since the inputbar was leaving the adjust mode in a broken state before. I was under the impression that hiding the index did the same thing, but it actually only does it when the adjust mode was inputbar: Lines 1245 to 1248 in b794eb2
I guess this could be cleaned up, and the adjust mode can be restored. |
Exactly, this PR seemed to go in the direction of improving this behavior, hence my suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement the changes mentioned by @jdujava.
Sorry, I stopped using Zathura due to growing frustration with some less trivial bugs. I think it'd be best if someone else picked up this patch. |
Zathura sets a special adjust mode before showing the inputbar. Remaining in that mode after it has been hidden breaks things like rotation, so reset to none.