Add macOS M1 runner testing configuration for PRs and scheduled tests #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.8 and Python 3.9 are not yet available in the version manifest, I had flagged this earlier today at actions/setup-python#808 |
agriyakhetarpal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3791 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 257 257
Lines 20802 20802
========================================
Hits 20718 20718
Misses 84 84 ☔ View full report in Codecov by Sentry. |
8 tasks
kratman
reviewed
Jan 31, 2024
agriyakhetarpal
commented
Feb 1, 2024
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
agriyakhetarpal
requested review from
martinjrobins,
Saransh-cpp and
arjxn-py
as code owners
agriyakhetarpal
commented
Feb 1, 2024
kratman
reviewed
Feb 1, 2024
|
Looks like they did, feel free to approve and merge |
arjxn-py
approved these changes
Feb 1, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
…pybamm-team#3791) * Add macOS M1 runner configuration for PR and scheduled tests See pybamm-team#3789, pybamm-team#3462 * Add `macos-14` to test conditions * Exclude Python 3.8 and 3.9 for now from testing * Apply suggestions from code review Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Remove some missed comments --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR configures the workflows to include tests for the new GitHub Actions M1 runners.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: