New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary for loop when using get_axis_num #8356

Merged

andersy005 merged 2 commits into pydata:main from Illviljan:variable_no_axis_num_loop

Oct 22, 2023

Contributor

Illviljan commented Oct 21, 2023 •

edited

Loading

Noticed an unnecessary for loop when playing around with self.get_axis_num in #8344.

Illviljan added 2 commits

October 21, 2023 22:32


          Tuple loop is not needed

84aac6d


          dims are usually tuple[Hashable, ...]

29bdfa7

max-sixty approved these changes

View reviewed changes

andersy005 approved these changes

View reviewed changes

andersy005 merged commit b0bb86e into pydata:main

27 of 28 checks passed

Illviljan deleted the variable_no_axis_num_loop branch

October 22, 2023 04:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet