Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to broadcast when global option arithmetic_broadcast=False #8784

Merged
merged 16 commits into from
Mar 13, 2024
Merged

Do not attempt to broadcast when global option arithmetic_broadcast=False #8784

merged 16 commits into from
Mar 13, 2024

Conversation

etienneschalk
Copy link
Contributor

@etienneschalk etienneschalk commented Feb 25, 2024 •
edited by dcherian
Loading

Follow-up PR after #8698

Motive

Refer to #8698 for history

In this PR more specifically:

  • Added a global option, arithmetic_broadcast, =True by default (current state)
  • If arithmetic_broadcast=False , _binary_op raises an error with message:
arithmetic broadcast is disabled via global option

Unrelated

Also adds a decorator to handle the optional dependency dask_expr

@etienneschalk etienneschalk changed the title New global option arithmetic_join=False Do not attempt to broadcast when global option arithmetic_broadcast=False Feb 25, 2024
@etienneschalk etienneschalk marked this pull request as ready for review February 25, 2024 14:35
@etienneschalk
Copy link
Contributor Author

cc @dcherian

dcherian
dcherian reviewed Feb 25, 2024
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
dcherian
dcherian reviewed Feb 25, 2024
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
dcherian
dcherian reviewed Feb 25, 2024
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
dcherian
dcherian reviewed Mar 3, 2024
View reviewed changes
doc/whats-new.rst Outdated Show resolved Hide resolved
dcherian
dcherian approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, I like it!

Thanks @etienneschalk

@dcherian dcherian added the plan to merge Final call for comments label Mar 3, 2024
@dcherian dcherian merged commit 11f89ec into pydata:main Mar 13, 2024
29 checks passed
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 13, 2024
@dcherian
Revert "Do not attempt to broadcast when global option ``arithmetic_b…
7be08c4 
…roadcast=False`` (pydata#8784)"

This reverts commit 11f89ec.
@dcherian dcherian mentioned this pull request Mar 13, 2024
Closed
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 13, 2024
@dcherian
Revert "Do not attempt to broadcast when global option ``arithmetic_b…
7fdfcb2 
…roadcast=False`` (pydata#8784)"

This reverts commit 11f89ec.
keewis added a commit to dcherian/xarray that referenced this pull request Mar 13, 2024
@keewis
Revert "Do not attempt to broadcast when global option ``arithmetic_b…
fdf7144 
…roadcast=False`` (pydata#8784)"

This reverts commit 11f89ec.
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 15, 2024
@dcherian
Merge branch 'main' into state-machine
3c92ddf 
* main: (31 commits)
  correctly encode/decode _FillValues/missing_values/dtypes for packed data (pydata#8713)
  Expand use of `.oindex` and `.vindex` (pydata#8790)
  Return a dataclass from Grouper.factorize (pydata#8777)
  [skip-ci] Fix upstream-dev env (pydata#8839)
  Add dask-expr for windows envs (pydata#8837)
  [skip-ci] Add dask-expr dependency to doc.yml (pydata#8835)
  Add `dask-expr` to environment-3.12.yml (pydata#8827)
  Make list_chunkmanagers more resilient to broken entrypoints (pydata#8736)
  Do not attempt to broadcast when global option ``arithmetic_broadcast=False`` (pydata#8784)
  try to get the `upstream-dev` CI to complete again (pydata#8823)
  Bump the actions group with 1 update (pydata#8818)
  Update documentation for clarity (pydata#8817)
  DOC: link to zarr.convenience.consolidate_metadata (pydata#8816)
  Refactor Grouper objects (pydata#8776)
  Grouper object design doc (pydata#8510)
  Bump the actions group with 2 updates (pydata#8804)
  tokenize() should ignore difference between None and {} attrs (pydata#8797)
  fix: remove Coordinate from __all__ in xarray/__init__.py (pydata#8791)
  Fix non-nanosecond casting behavior for `expand_dims` (pydata#8782)
  Migrate treenode module. (pydata#8757)
  ...
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 16, 2024
@dcherian
Merge branch 'main' into flox-quantile
34032ef 
* main: (42 commits)
  correctly encode/decode _FillValues/missing_values/dtypes for packed data (pydata#8713)
  Expand use of `.oindex` and `.vindex` (pydata#8790)
  Return a dataclass from Grouper.factorize (pydata#8777)
  [skip-ci] Fix upstream-dev env (pydata#8839)
  Add dask-expr for windows envs (pydata#8837)
  [skip-ci] Add dask-expr dependency to doc.yml (pydata#8835)
  Add `dask-expr` to environment-3.12.yml (pydata#8827)
  Make list_chunkmanagers more resilient to broken entrypoints (pydata#8736)
  Do not attempt to broadcast when global option ``arithmetic_broadcast=False`` (pydata#8784)
  try to get the `upstream-dev` CI to complete again (pydata#8823)
  Bump the actions group with 1 update (pydata#8818)
  Update documentation for clarity (pydata#8817)
  DOC: link to zarr.convenience.consolidate_metadata (pydata#8816)
  Refactor Grouper objects (pydata#8776)
  Grouper object design doc (pydata#8510)
  Bump the actions group with 2 updates (pydata#8804)
  tokenize() should ignore difference between None and {} attrs (pydata#8797)
  fix: remove Coordinate from __all__ in xarray/__init__.py (pydata#8791)
  Fix non-nanosecond casting behavior for `expand_dims` (pydata#8782)
  Migrate treenode module. (pydata#8757)
  ...
dcherian added a commit to kmsquire/xarray that referenced this pull request Mar 21, 2024
@dcherian
Merge remote-tracking branch 'upstream/main' into feature/rolling-pad
072e87c 
* upstream/main: (765 commits)
  increase typing annotations coverage in `xarray/core/indexing.py` (pydata#8857)
  pandas 3 MultiIndex fixes (pydata#8847)
  FIX: adapt handling of copy keyword argument in scipy backend for numpy >= 2.0dev (pydata#8851)
  FIX: do not cast _FillValue/missing_value in CFMaskCoder if _Unsigned is provided (pydata#8852)
  Implement setitem syntax for `.oindex` and `.vindex` properties (pydata#8845)
  Support pandas copy-on-write behaviour (pydata#8846)
  correctly encode/decode _FillValues/missing_values/dtypes for packed data (pydata#8713)
  Expand use of `.oindex` and `.vindex` (pydata#8790)
  Return a dataclass from Grouper.factorize (pydata#8777)
  [skip-ci] Fix upstream-dev env (pydata#8839)
  Add dask-expr for windows envs (pydata#8837)
  [skip-ci] Add dask-expr dependency to doc.yml (pydata#8835)
  Add `dask-expr` to environment-3.12.yml (pydata#8827)
  Make list_chunkmanagers more resilient to broken entrypoints (pydata#8736)
  Do not attempt to broadcast when global option ``arithmetic_broadcast=False`` (pydata#8784)
  try to get the `upstream-dev` CI to complete again (pydata#8823)
  Bump the actions group with 1 update (pydata#8818)
  Update documentation for clarity (pydata#8817)
  DOC: link to zarr.convenience.consolidate_metadata (pydata#8816)
  Refactor Grouper objects (pydata#8776)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting
2 participants
@etienneschalk @dcherian