Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two bugs in DataTree.update() #9214

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix two bugs in DataTree.update() #9214

merged 2 commits into from
Jul 8, 2024

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Jul 7, 2024

  1. Fix handling of coordinates on a Dataset argument (previously these were silently dropped).
  2. Do not copy inherited coordinates down to lower level nodes.
  • Tests added

@shoyer
Fix two bugs in DataTree.update()
2f65033 
1. Fix handling of coordinates on a Dataset argument (previously these
   were silently dropped).
2. Do not copy inherited coordinates down to lower level nodes.
@shoyer shoyer requested a review from TomNicholas July 7, 2024 22:12
@shoyer shoyer mentioned this pull request Jul 7, 2024
Open
@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Jul 8, 2024
@shoyer
Copy link
Member Author

shoyer commented Jul 8, 2024

@TomNicholas can you please take a quick look here?

TomNicholas
TomNicholas approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @shoyer !

@shoyer shoyer merged commit 179c670 into pydata:main Jul 8, 2024
34 checks passed
@shoyer shoyer deleted the datatree-fix-update branch July 8, 2024 17:12
dcherian added a commit to dcherian/xarray that referenced this pull request Jul 11, 2024
@dcherian
Merge branch 'main' into grouper-public-api
c94d9c2 
* main:
  exclude the bots from the release notes (pydata#9235)
  switch the documentation to run with `numpy>=2` (pydata#9177)
  `numpy` 2 compatibility in the iris code paths (pydata#9156)
  `numpy` 2 compatibility in the `netcdf4` and `h5netcdf` backends (pydata#9136)
  Fix time indexing regression in `convert_calendar` (pydata#9192)
  Use duckarray assertions in test_coding_times (pydata#9226)
  Use reshape and ravel from duck_array_ops in coding/times.py (pydata#9225)
  Cleanup test_coding_times.py (pydata#9223)
  Only use necessary dims when creating temporary dataarray (pydata#9206)
  Fix two bugs in DataTree.update() (pydata#9214)
  Use numpy 2.0-compat `np.complex64` dtype in test (pydata#9217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomNicholas TomNicholas TomNicholas approved these changes

Assignees
No one assigned
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
DataTree integration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoyer @TomNicholas