Support for CarpetBombing task #356
Conversation
|
@DanAlbert - merge PR #357 first, I'll rebase this and then the tests here will pass. |
332fg-raven
force-pushed
the
feature/support-for-big-formation-carpet-bombing
branch
from
69d3199
to
d08cd2c
Compare
|
@DanAlbert - rebased, ready to be merged. |
| def __eq__(self, other: Any) -> bool: | ||
| if isinstance(other, str): | ||
| return self.value == other | ||
| if isinstance(other, Expend): |
There was a problem hiding this comment.
Close enough so meh, non-blocking, but for the future just return super().__eq__(other) after doing any custom checks.
| # hardcoded parameters are present in .miz file, but not visible in Mission Editor | ||
| self.params = { | ||
| "altitude": alt_above, | ||
| "altitudeEnabled": True if alt_above != CarpetBombing.DEFAULT_ALT else False, |
There was a problem hiding this comment.
I don't think this is actually right. I suspect this field is supposed to be "did the caller make a choice, or did they use the default?". This can't distinguish between a chosen altitude of 2000 and a default behavior. For that you need alt_above: int | None = None.
I've also got no idea what the impact of getting this wrong is. Might be just UI behavior in the ME? I won't block on this for now, but for future reference, that's how this thing ought to be written.
There was a problem hiding this comment.
Also, fyi, this is just a more verbose way to write "altitudeEnabled": alt_above != CarpetBombing.DEFAULT_ALT
332fg-raven
deleted the
feature/support-for-big-formation-carpet-bombing
branch
This change allows WWIIBigFormation to use Carpet Bombing task. Removed duplicate tests for big formation which crept in with PR pydcs#351
This change allows WWIIBigFormation to use Carpet Bombing task. Removed duplicate tests for big formation which crept in with PR pydcs#351
This change allows WWIIBigFormation to use Carpet Bombing task.
Removed duplicate tests for big formation which crept in with PR #351