-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove python2 #856
Conversation
Tests need to be run with corresponding invocations that also has six removed. |
@kuwv Thanks for openning this, but @bitprophet is actively working on removing Python 2 (after a long time of dealing with other priorities than FOSS). The migration of invoke, fabric and paramiko from Travis to CircleCI was a blocker which is now complete. He is working on removing Python 2 from invoke first since it has least dependencies and Fabric and paramiko depend on Invoke. |
What @neozenith said, though so far I've only started on Invocations myself (I think before that PR over there was filed). So you may want to just close that one, but I'll make a note to build off this one when I turn my attention to Invoke-proper. As with any PR, I may end up using a scalpel, but especially for this kind of more grunt-work it'll save me a lot of time regardless, so thank you! |
@bitprophet, @neozenith, glad this will be useful then. I'll close the invocations PR. |
One caveat, I updated to pep517 build for setuptools. Use:
instead of:
Also, |
@neozenith Do you need me to refresh this? Or, do you have a time frame? |
Gonna take a crack at applying this now and hope it saves me some time! 🙏🏻 Invoke is now up on my Py2 chopping block. |
Rebased onto latest main, made some minor changes, and merged back into main. I'll take the rest from here - thanks! 🙌🏻 |
Huzzah!!! |
Python 2 has been deprecated for over a year now. This pull request removes integrations with invoke with six that are used to support now deprecated Python2 compatibility. Removing this will allow builds to be more simplified while allow integration with more modern tooling from the Python ecosystem.
see corresonding: pyinvoke/invocations#30