Optimize exception handling in import_module() #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
+ Coverage 92.82% 92.92% +0.09%
==========================================
Files 94 95 +1
Lines 10836 10922 +86
==========================================
+ Hits 10059 10149 +90
+ Misses 777 773 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
force-pushed
the
performance-boosts
branch
from
5c2380b
to
c525361
Compare
DanielNoord
reviewed
Jun 27, 2023
DanielNoord
approved these changes
Jun 27, 2023
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Small performance boost. Don't repeat the same import operation for modules like
ntpaththat only exist on certain platforms (e.g. windows).