Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release branch 3.0.0a7 #2242

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Release branch 3.0.0a7 #2242

merged 2 commits into from
Jul 8, 2023

Conversation

Pierre-Sassoulas
Copy link
Member

No description provided.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0a7 milestone Jul 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jul 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (rebase) July 8, 2023 05:44
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #2242 (a29effd) into main (e91a3b5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2242   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          94       94           
  Lines       10941    10941           
=======================================
  Hits        10151    10151           
  Misses        790      790           
Flag Coverage Δ
linux 92.58% <100.00%> (ø)
pypy 90.89% <100.00%> (ø)
windows 92.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/__pkginfo__.py 100.00% <100.00%> (ø)

@jacobtylerwalls
Copy link
Member

In #1867 (review) I was hoping not to merge the Try node changes until we had 3.0.0a7 released, but now that the Try node changes are merged in, we have two large pylint PRs to do at the same time.

I'm okay with merging this as is, but in terms of doing the pylint upgrades, should we just keep the two PRs separate, and have the first one pin to a specific commit since we don't have another separate alpha for it?

@Pierre-Sassoulas
Copy link
Member Author

We could also cheat/rewrite the history or merge a branch install in pylint ?

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or merge a branch install in pylint

I'll just pin to the hotfix commit on the existing pylint upgrade PR and that pin will only be there for a day or two on main until we do the Try node update PR, and it won't be a problem.

Thanks!

@Pierre-Sassoulas Pierre-Sassoulas merged commit 8975066 into main Jul 8, 2023
19 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-3.0.0a7 branch July 8, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants