[refactor] Remove variable for thing that never change in test_inference

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Small thing that annoy me: Having to go check a constant 5000 lines above the test I'm looking at and the constant will never ever change.

[codecov]

Codecov Report

Merging #2243 (3334919) into main (e91a3b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2243   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          94       94           
  Lines       10941    10941           
=======================================
  Hits        10151    10151           
  Misses        790      790           

Flag	Coverage Δ
linux	92.58% <ø> (ø)
pypy	90.89% <ø> (ø)
windows	92.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[jacobtylerwalls]

I like getting rid of BOOL_SPECIAL_METHOD because I think __bool__ reads much better but am -0 on the other change. I generally like extracting a constant from a string that has to be used repeatedly, as it guards against typos.

[Pierre-Sassoulas]

Wouldn't the test fail and show a diff of the two strings in case of typo ?

[jacobtylerwalls]

Good point, I forgot these are unit tests.

Having to go check a constant 5000 lines above

You gotta use mouse hovering! :D