Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assigned_stmts() to PEP 695 nodes #2320

Merged

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Oct 15, 2023

Type of Changes

Type
🐛 Bug fix

Description

Closes pylint-dev/pylint#9098

(see separate pylint PR with regression test for pylint-dev/pylint#9110)



@decorators.yes_if_nothing_inferred
def generic_type_assigned_stmts(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modeled on the 3.10 match work just above this.

@jacobtylerwalls jacobtylerwalls added the Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer label Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #2320 (411414f) into main (ab75985) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2320   +/-   ##
=======================================
  Coverage   92.85%   92.86%           
=======================================
  Files          94       94           
  Lines       11056    11065    +9     
=======================================
+ Hits        10266    10275    +9     
  Misses        790      790           
Flag Coverage Δ
linux 92.67% <100.00%> (+<0.01%) ⬆️
pypy 90.99% <88.88%> (-0.01%) ⬇️
windows 92.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/nodes/node_classes.py 94.83% <100.00%> (+0.01%) ⬆️
astroid/protocols.py 90.28% <100.00%> (+0.06%) ⬆️

@jacobtylerwalls jacobtylerwalls added backport maintenance/3.3.x and removed Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer labels Oct 15, 2023
@jacobtylerwalls jacobtylerwalls merged commit d7be465 into pylint-dev:main Oct 15, 2023
24 checks passed
@jacobtylerwalls jacobtylerwalls deleted the assigned-stmts-typevar branch October 15, 2023 19:58
github-actions bot pushed a commit that referenced this pull request Oct 15, 2023
jacobtylerwalls added a commit that referenced this pull request Oct 15, 2023
(cherry picked from commit d7be465)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/3.3.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done Crash 💥 python 3.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash AttributeError: 'TypeVar' object has no attribute 'assigned_stmts'
3 participants