Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useless-suppression Pylint warning #2548

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

correctmost
Copy link
Contributor

Type of Changes

Type
🔨 Refactoring

Description

This PR fixes the following warning (Pylint 3.2.7):

astroid/builder.py:247:0: I0021: Useless suppression of 'unidiomatic-typecheck' (useless-suppression)

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (887668b) to head (1974a4d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2548   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files          93       93           
  Lines       11081    11081           
=======================================
  Hits        10303    10303           
  Misses        778      778           
Flag Coverage Δ
linux 92.86% <ø> (ø)
pypy 92.97% <ø> (ø)
windows 92.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/builder.py 94.19% <ø> (ø)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we should upgrade the pylint version to 3.2.7 at the same time

@correctmost
Copy link
Contributor Author

I suppose we should upgrade the pylint version to 3.2.7 at the same time

Thanks, the version has been bumped

@Pierre-Sassoulas Pierre-Sassoulas merged commit 8573b68 into pylint-dev:main Sep 8, 2024
20 checks passed
@correctmost correctmost deleted the cm/fix-pylint-warning branch September 8, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants