Fix a false positive for no-member.
#8778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8778 +/- ##
=======================================
Coverage 95.75% 95.76%
=======================================
Files 173 173
Lines 18604 18604
=======================================
+ Hits 17815 17816 +1
+ Misses 789 788 -1
|
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
Work in progress
False Positive π¦
mbyrnepr2
force-pushed
the
8759_false_positive_no_member
branch
from
b546d7d
to
7a8d743
Compare
This comment has been minimized.
This comment has been minimized.
mbyrnepr2
force-pushed
the
8759_false_positive_no_member
branch
from
7a8d743
to
5bad8d2
Compare
This comment has been minimized.
This comment has been minimized.
mbyrnepr2
force-pushed
the
8759_false_positive_no_member
branch
from
5bad8d2
to
4530e50
Compare
This comment has been minimized.
This comment has been minimized.
mbyrnepr2
force-pushed
the
8759_false_positive_no_member
branch
from
4530e50
to
1e43834
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 1e43834 |
|
Is it still a draft @mbyrnepr2 ? |
|
Thanks for the reminder @Pierre-Sassoulas. Itβs been a while since I thought about it and I think I must have had a doubt about it to leave it as a draft. |
Pierre-Sassoulas
requested changes
Aug 17, 2023
| obj_a = A() | ||
| obj_a.value += 1 # [no-member] | ||
| obj_a.value += 1 |
There was a problem hiding this comment.
A review comment got lost: Here we'd introduce a false negative, running the code raise an error:
Traceback (most recent call last):
File "/home/pierre/pylint/doc/a.py", line 12, in <module>
obj_a = A(1)
TypeError: A() takes no arguments
β¦ibute that is annotated in a class body. Closes pylint-dev#8759
mbyrnepr2
force-pushed
the
8759_false_positive_no_member
branch
from
1e43834
to
f056878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive for
no-memberwhen accessing a no-value attribute that is annotated in a class body.Closes #8759