Clean up tests that had min_pyver=3.7 test setting #8792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike py-version, which is still meaningful for lower versions, min_pyver doesn't have any meaning when it's already the lowest supported Python interpreter for launching pylint.
jacobtylerwalls
added
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8792 +/- ##
==========================================
- Coverage 95.85% 95.83% -0.02%
==========================================
Files 173 173
Lines 18510 18526 +16
==========================================
+ Hits 17742 17755 +13
- Misses 768 771 +3 |
DanielNoord
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refs #4683
Unlike py-version, which is still meaningful for lower versions,
min_pyver doesn't have any meaning when it's already the lowest
supported Python interpreter for launching pylint.
Mostly this PR just deletes or shortens .rc files associated with tests; in a few instances, I combined or renamed files to avoid having so many uninformative "py37" suffixes. (But I didn't aim to eradicate them completely; in some cases having the extra file is nice.)
We could do this again for min_pyver=3.8, since 3.8 is minimum on main; see #6306.