Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astroid version to 3.1.0 #9457

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 23, 2024

@cdce8p cdce8p added Astroid Related to astroid Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Feb 23, 2024
@cdce8p cdce8p added this to the 3.0.4 milestone Feb 23, 2024
@cdce8p cdce8p added backport maintenance/3.3.x dependency Label for github dependabot and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Feb 23, 2024

This comment has been minimized.

@cdce8p
Copy link
Member Author

cdce8p commented Feb 23, 2024

@jacobtylerwalls Would you mind taking a look at the remaining issues? One for used-before-assignment is related to pylint-dev/astroid#2345, the other invalid-name (3.12 only) likely to pylint-dev/astroid#2330.

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Feb 23, 2024

Sure thing. I already have a PR with the invalid_name update, let me retarget this branch and see if that does it.

@jacobtylerwalls

This comment was marked as resolved.

@jacobtylerwalls
Copy link
Member

As described at #9196, there was a hard limit on the number of test files under a dir, so there was some shuffling.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (d4f0ef7) to head (145b911).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9457      +/-   ##
==========================================
+ Coverage   95.81%   95.82%   +0.01%     
==========================================
  Files         173      173              
  Lines       18792    18798       +6     
==========================================
+ Hits        18005    18013       +8     
+ Misses        787      785       -2     
Files Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.62% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Feb 23, 2024

I would suggest not backporting, as it will introduce new messages most likely (or at least possibly, since we're now visiting type alias nodes correctly)

@jacobtylerwalls
Copy link
Member

Let's just do pylint 3.1 this weekend.

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 145b911

@cdce8p cdce8p modified the milestones: 3.0.4, 3.1.0 Feb 23, 2024
@cdce8p
Copy link
Member Author

cdce8p commented Feb 23, 2024

Thanks @jacobtylerwalls 🚀 Release 3.1.0 instead sounds good to me. The changes here look fine, I just can't approve my own PR.

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cdce8p cdce8p merged commit f499686 into pylint-dev:main Feb 23, 2024
48 checks passed
@cdce8p cdce8p deleted the update-astroid-3.1.0 branch February 23, 2024 20:06
@Pierre-Sassoulas
Copy link
Member

I'm going to release 3.0.4 now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Astroid Related to astroid dependency Label for github dependabot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants