-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Pyodide support #1456
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c7ef275
feat: add Pyodide support
henryiii 0b285d0
Try to fix xbuildenv path
hoodmane b2ad069
fix: remove pinning on pyodide
henryiii 1109010
Update for Pyodide 0.26.0a5
hoodmane 040f5ec
Install pyodide-build from pypi
hoodmane 53490d1
Update docs/options.md
hoodmane b963568
Unxfail things that look like they were just a version mismatch
hoodmane a4b2aeb
refactor: add constraints for pyodide
henryiii acd81fd
chore: minor cleanup
henryiii ed2d09d
Apply suggestions from code review
henryiii 99831ec
Apply suggestion from code review
mayeut eabc33e
refactor: minor touchup
henryiii 202174a
ci: xfail the pyodide test
henryiii 013e811
review: use a pinned version of node
mayeut 4ac060d
fix tests
mayeut 9239f25
review: error out on Windows
mayeut 4373527
test: check node & test on macos arm64
mayeut c90b018
chore: minor cleanup
mayeut 809427e
Add reference to emscripten libc issue
hoodmane b1b7317
Apply suggestion from code review
mayeut 560126f
review: use a pinned pip in test virtual environment
mayeut 2fac554
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 43d6042
chore: rework test virtual environment seed packages
mayeut 4a8bf61
chore: workaround direct invocation of pytest
mayeut 7aade41
Use release version of pyodide
hoodmane fa7a7d8
Merge branch 'main' into pr/1456
mayeut 9b01189
fix: tests for 0.26.0 & parallel initialization of xbuildenv
mayeut 917646c
Debug CI
hoodmane f13a0b7
fix: test/test_build_frontend_args.py
mayeut 12d90c9
Merge branch 'main' into pr/1456
mayeut 6ea11f9
Revert "Debug CI"
mayeut aac446a
Merge branch 'main' into emscripten
henryiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this works? I have no idea why it passes locally though??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that it fixed it indeed =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems too have been style/color as you pointed out.
I don't know why it passes locally either...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something is checking for the GitHub actions var and assuming it is in a CI run that supports color?