Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Pyodide support #1456

Merged
merged 32 commits into from
May 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c7ef275
feat: add Pyodide support
henryiii May 18, 2024
0b285d0
Try to fix xbuildenv path
hoodmane May 19, 2024
b2ad069
fix: remove pinning on pyodide
henryiii May 20, 2024
1109010
Update for Pyodide 0.26.0a5
hoodmane May 21, 2024
040f5ec
Install pyodide-build from pypi
hoodmane May 21, 2024
53490d1
Update docs/options.md
hoodmane May 24, 2024
b963568
Unxfail things that look like they were just a version mismatch
hoodmane May 24, 2024
a4b2aeb
refactor: add constraints for pyodide
henryiii May 24, 2024
acd81fd
chore: minor cleanup
henryiii May 24, 2024
ed2d09d
Apply suggestions from code review
henryiii May 24, 2024
99831ec
Apply suggestion from code review
mayeut May 25, 2024
eabc33e
refactor: minor touchup
henryiii May 26, 2024
202174a
ci: xfail the pyodide test
henryiii May 26, 2024
013e811
review: use a pinned version of node
mayeut May 26, 2024
4ac060d
fix tests
mayeut May 26, 2024
9239f25
review: error out on Windows
mayeut May 26, 2024
4373527
test: check node & test on macos arm64
mayeut May 26, 2024
c90b018
chore: minor cleanup
mayeut May 26, 2024
809427e
Add reference to emscripten libc issue
hoodmane May 26, 2024
b1b7317
Apply suggestion from code review
mayeut May 27, 2024
560126f
review: use a pinned pip in test virtual environment
mayeut May 27, 2024
2fac554
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 27, 2024
43d6042
chore: rework test virtual environment seed packages
mayeut May 27, 2024
4a8bf61
chore: workaround direct invocation of pytest
mayeut May 27, 2024
7aade41
Use release version of pyodide
hoodmane May 27, 2024
fa7a7d8
Merge branch 'main' into pr/1456
mayeut May 27, 2024
9b01189
fix: tests for 0.26.0 & parallel initialization of xbuildenv
mayeut May 27, 2024
917646c
Debug CI
hoodmane May 27, 2024
f13a0b7
fix: test/test_build_frontend_args.py
mayeut May 27, 2024
12d90c9
Merge branch 'main' into pr/1456
mayeut May 27, 2024
6ea11f9
Revert "Debug CI"
mayeut May 27, 2024
aac446a
Merge branch 'main' into emscripten
henryiii May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/test_build_frontend_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ def test_build_frontend_args(tmp_path, capfd, frontend_name):
project.generate(project_dir)

# the build will fail because the frontend is called with '-h' - it prints the help message
add_env = {"CIBW_BUILD_FRONTEND": f"{frontend_name}; args: -h"}
if utils.platform == "pyodide":
add_env["TERM"] = "dumb" # disable color / style
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this works? I have no idea why it passes locally though??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that it fixed it indeed =)

Copy link
Member

@mayeut mayeut May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems too have been style/color as you pointed out.
I don't know why it passes locally either...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something is checking for the GitHub actions var and assuming it is in a CI run that supports color?

with pytest.raises(subprocess.CalledProcessError):
utils.cibuildwheel_run(
project_dir,
add_env={"CIBW_BUILD_FRONTEND": f"{frontend_name}; args: -h"},
single_python=True,
)
utils.cibuildwheel_run(project_dir, add_env=add_env, single_python=True)

captured = capfd.readouterr()
print(captured.out)
Expand Down
Loading