Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect constraints when building with pip #1818

Merged
merged 1 commit into from
May 10, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 10, 2024

When building a project that has a pyproject.toml, constraints are not respected when building with the pip frontend.

This commit fixes this by using the same tricks as for the build frontend.

When building a project that has a `pyproject.toml`, constraints
are not respected when building with the `pip` frontend.

This commit fixes this by using the same tricks as for the `build` frontend.
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like constraints affecting isolated builds (how does one excite which of the half a dozen or so build backends are constrained?), but we should be consistent between pip and build.

@henryiii henryiii merged commit 3ea0a6c into pypa:main May 10, 2024
18 of 19 checks passed
@mayeut mayeut deleted the pip-respect-constraints branch May 11, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants