Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support linux builds from macOS again #1968

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

henryiii
Copy link
Contributor

One possible fix for #1962. Doesn't fix Windows, though.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@mayeut
Copy link
Member

mayeut commented Aug 15, 2024

I had some issues with ustar c.f. #1434 (comment)
Does gnutar works in your case (only on host side, macOS) ?
Maybe it's time to revisit docker cp but I'm not hopeful on Travis CI just yet...

@henryiii
Copy link
Contributor Author

macOS doesn't have gnutar as an option in it's bsdtar.

tar(bsdtar): manipulate archive files
First option must be a mode specifier:
  -c Create  -r Add/Replace  -t List  -u Update  -x Extract
Common Options:
  -b #  Use # 512-byte records per I/O block
  -f <filename>  Location of archive
  -v    Verbose
  -w    Interactive
Create: tar -c [options] [<file> | <dir> | @<archive> | -C <dir> ]
  <file>, <dir>  add these items to archive
  -z, -j, -J, --lzma  Compress archive with gzip/bzip2/xz/lzma
  --format {ustar|pax|cpio|shar}  Select archive format
  --exclude <pattern>  Skip files that match pattern
  -C <dir>  Change to <dir> before processing remaining files
  @<archive>  Add entries from <archive> to output
List: tar -t [options] [<patterns>]
  <patterns>  If specified, list only entries that match
Extract: tar -x [options] [<patterns>]
  <patterns>  If specified, extract only entries that match
  -k    Keep (don't overwrite) existing files
  -m    Don't restore modification times
  -O    Write entries to stdout, don't restore to disk
  -p    Restore permissions (including ACLs, owner, file flags)
bsdtar 3.5.3 - libarchive 3.5.3 zlib/1.2.12 liblzma/5.4.3 bz2lib/1.0.8

@mayeut
Copy link
Member

mayeut commented Aug 17, 2024

It's not listed in --help, if you do man tar, it redirects you to man libarchive-formats which lists gnutar c.f. #1434 (comment) & #1434 (comment)

@henryiii
Copy link
Contributor Author

Copying project into container...

    + mkdir -p /project
tar: gnutar: Invalid archive format
Try `tar --help' or `tar --usage' for more information.
tar: Write error

                                                              ✕ 0.78s

@mayeut
Copy link
Member

mayeut commented Aug 19, 2024

It shall only be on host side of tar create for macOS only (I pushed a commit to that effect).
Would this commit solve the issue you're seeing locally ?

@henryiii henryiii marked this pull request as draft August 21, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants